Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1470263004: Add "-i" to command line to specify leading indent. (Closed)

Created:
5 years ago by Bob Nystrom
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add "-i" to command line to specify leading indent. Fix #464. R=sigmund@google.com Committed: https://github.com/dart-lang/dart_style/commit/ef9db2d553d03ea6a1e6c3667487400c73fa34b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -22 lines) Patch
M bin/format.dart View 4 chunks +17 lines, -3 lines 0 comments Download
M lib/src/formatter_options.dart View 2 chunks +4 lines, -1 line 0 comments Download
M lib/src/io.dart View 1 chunk +2 lines, -1 line 0 comments Download
M test/command_line_test.dart View 6 chunks +40 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bob Nystrom
5 years ago (2015-11-25 00:20:40 UTC) #2
Siggi Cherem (dart-lang)
lgtm - but note that for #464 we also need to be able to specify ...
5 years ago (2015-11-25 00:23:50 UTC) #4
Bob Nystrom
On 2015/11/25 00:23:50, Siggi Cherem (dart-lang) wrote: > lgtm - but note that for #464 ...
5 years ago (2015-11-25 01:21:19 UTC) #5
Bob Nystrom
Committed patchset #1 (id:1) manually as ef9db2d553d03ea6a1e6c3667487400c73fa34b8 (presubmit successful).
5 years ago (2015-11-25 01:21:44 UTC) #6
Siggi Cherem (dart-lang)
5 years ago (2015-11-25 01:29:22 UTC) #7
Message was sent while issue was closed.
On 2015/11/25 01:21:19, Bob Nystrom wrote:
> On 2015/11/25 00:23:50, Siggi Cherem (dart-lang) wrote:
> > lgtm - but note that for #464 we also need to be able to specify a statement
> as
> > the entire input to the formatter
> > 
> >   echo "callfoo();" | dartfmt
> > 
> > will fail today saying that it needs a function body.
> 
> Oh, dang. I thought it did that already. Can you file a bug so I don't forget
> this?

Sure, here it is https://github.com/dart-lang/dart_style/issues/470

Thanks!

Powered by Google App Engine
This is Rietveld 408576698