Issue 14698003: Report CTEC.MULTIPLE_SUPER_INITIALIZERS

Issue 14698003: Report CTEC.MULTIPLE_SUPER_INITIALIZERS (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report CTEC.MULTIPLE_SUPER_INITIALIZERS R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22546

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -16 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1 chunk	+1 line, -1 line	1 comment	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	3 chunks	+22 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	2 chunks	+11 lines, -11 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jwren

LGTM https://codereview.chromium.org/14698003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java (right): https://codereview.chromium.org/14698003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java#newcode612 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:612: MULTIPLE_SUPER_INITIALIZERS("Constructor may have at most one 'super' initializer."), ...

7 years, 7 months ago (2013-05-09 06:37:28 UTC) #2

scheglov

7 years, 7 months ago (2013-05-09 15:04:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22546 (presubmit successful).

Expand Messages | Collapse Messages