Issue 14696012: Make web-socket pass AutobanhTestSuite.

Issue 14696012: Make web-socket pass AutobanhTestSuite. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make web-socket pass AutobanhTestSuite. BUG=http://code.google.com/p/dart/issues/detail?id=10506 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22502

Patch Set 2 : Fixes #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+218 lines, -122 lines)			Patch
M	sdk/lib/io/string_transformer.dart	View		1 chunk	+23 lines, -1 line	0 comments	Download
M	sdk/lib/io/websocket.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/websocket_impl.dart	View	1	17 chunks	+101 lines, -46 lines	0 comments	Download
M	sdk/lib/utf/utf_stream.dart	View		3 chunks	+62 lines, -42 lines	0 comments	Download
M	tests/standalone/io/string_decoder_test.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/standalone/io/web_socket_protocol_processor_test.dart	View		5 chunks	+28 lines, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM! Thanks for testing with the AutobanhTestSuite WebSocket test suite. https://codereview.chromium.org/14696012/diff/1/sdk/lib/io/websocket.dart File sdk/lib/io/websocket.dart (right): https://codereview.chromium.org/14696012/diff/1/sdk/lib/io/websocket.dart#newcode39 ...

7 years, 7 months ago (2013-05-08 12:15:40 UTC) #2

Anders Johnsen

Committed patchset #2 manually as r22502 (presubmit successful).

7 years, 7 months ago (2013-05-08 12:40:34 UTC) #3

Anders Johnsen

7 years, 6 months ago (2013-06-11 12:23:47 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14696012/diff/1/sdk/lib/io/websocket.dart
File sdk/lib/io/websocket.dart (right):

https://codereview.chromium.org/14696012/diff/1/sdk/lib/io/websocket.dart#new...
sdk/lib/io/websocket.dart:39: *         }
On 2013/05/08 12:15:40, Søren Gjesse wrote:
> });

Done.

https://codereview.chromium.org/14696012/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/14696012/diff/1/sdk/lib/io/websocket_impl.dar...
sdk/lib/io/websocket_impl.dart:78: _fin = (byte & 0x80) != 0;
On 2013/05/08 12:15:40, Søren Gjesse wrote:
> Add comment
> 
> // The RSV1, RSV2 bits RSV3 most be all zero.

Done.

Expand Messages | Collapse Messages