Issue 14694002: Fix a broken oauth2 test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14694002: Fix a broken oauth2 test. (Closed)

Created:
7 years, 7 months ago by nweiz

Modified:
7 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a broken oauth2 test. TBR Committed: https://code.google.com/p/dart/source/detail?r=22203

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -13 lines)			Patch
	M	pkg/oauth2/lib/src/client.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/oauth2/test/client_test.dart	View		4 chunks	+5 lines, -12 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 manually as r22203 (presubmit successful).

7 years, 7 months ago (2013-04-30 21:25:10 UTC) #2

Bob Nystrom

7 years, 7 months ago (2013-04-30 21:56:54 UTC) #3

Message was sent while issue was closed.

One nit (which you can probably ignore since this is TBR) but LGTM.

https://codereview.chromium.org/14694002/diff/1/pkg/oauth2/test/client_test.dart
File pkg/oauth2/test/client_test.dart (right):

https://codereview.chromium.org/14694002/diff/1/pkg/oauth2/test/client_test.d...
pkg/oauth2/test/client_test.dart:120: expect(client.refreshCredentials(),
throwsA(isStateError));
You can use throwsStateError.

Expand Messages | Collapse Messages