Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 14693005: Update status file after dart:typed_data no longer causes mock compilation (Closed)

Created:
7 years, 7 months ago by ahe
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update status file after dart:typed_data no longer causes mock compilation R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=22792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M dart/tests/isolate/isolate.status View 1 chunk +1 line, -0 lines 0 comments Download
M dart/tests/standalone/standalone.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
When dart:typed_data imported dart:html, during d8 testing, dart2js would generate code that doesn't call main. ...
7 years, 7 months ago (2013-05-16 14:06:54 UTC) #1
Johnni Winther
lgtm
7 years, 7 months ago (2013-05-16 14:08:57 UTC) #2
Anton Muhin
lgtm lgtm and many thanks
7 years, 7 months ago (2013-05-16 14:09:21 UTC) #3
ahe
7 years, 7 months ago (2013-05-16 14:09:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22792 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698