Issue 146833007: Don’t call toString from debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146833007: Don’t call toString from debugger (Closed)

Created:
6 years, 11 months ago by hausner

Modified:
6 years, 11 months ago

Reviewers:
Cutch, john

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Jacob

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Don’t call toString from debugger Debugger no longer calls toString on objects. It continues to do so on known basic types like numbers, booleans, strings. This is necessary because toString() may have side effects. See issue 16229 for example. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=32003

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	runtime/bin/dbg_message.cc	View	1	2 chunks	+11 lines, -8 lines	0 comments	Download
	M	tests/standalone/debugger/tostring_throws_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

6 years, 11 months ago (2014-01-24 23:14:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r32003 (presubmit successful).

Expand Messages | Collapse Messages