Issue 14676020: Fix dartbug.com/10674:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14676020: Fix dartbug.com/10674: (Closed)

Created:
7 years, 7 months ago by Ivan Posva

Modified:
7 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix dartbug.com/10674: - Make sure that Dart_NewExternalTypedData returns a local handle. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22806

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -18 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View		3 chunks	+31 lines, -18 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/14676020/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/14676020/diff/1/runtime/vm/dart_api_impl.cc#newcode2498 runtime/vm/dart_api_impl.cc:2498: const ExternalTypedData& result = ExternalTypedData::Handle( isolate, here too ...

7 years, 7 months ago (2013-05-16 18:28:18 UTC) #2

Ivan Posva

7 years, 7 months ago (2013-05-16 18:33:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22806 (presubmit successful).

Expand Messages | Collapse Messages