Issue 146733003: Handle type checking of generic compile time constants.

Issue 146733003: Handle type checking of generic compile time constants. (Closed)

Created:
6 years, 11 months ago by Johnni Winther

Modified:
6 years, 8 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle type checking of generic compile time constants. BUG=http://dartbug.com/14348 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=32154 Committed: https://code.google.com/p/dart/source/detail?r=34871

Patch Set 2 : Add regression test. #

Total comments: 16

Patch Set 3 : Updated cf. comments #

Patch Set 6 : Fix for language/const_constructor3_test #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -23 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View	1 2 3 4 5	6 chunks	+10 lines, -11 lines	0 comments	Download
A	tests/language/const_constructor2_test.dart	View	1 2 3 4	1 chunk	+78 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1 2 3 4	2 chunks	+0 lines, -6 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 2 3 4	2 chunks	+0 lines, -6 lines	0 comments	Download
A	tests/language/regress_14348_test.dart	View	1 2 3 4	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/146733003/diff/30001/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (right): https://codereview.chromium.org/146733003/diff/30001/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode807 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:807: void potentiallyCheckType(Node node, 'elementType' -> 'type'? I think ...

6 years, 10 months ago (2014-01-29 10:44:23 UTC) #2

Johnni Winther

https://codereview.chromium.org/146733003/diff/30001/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (right): https://codereview.chromium.org/146733003/diff/30001/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode807 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:807: void potentiallyCheckType(Node node, On 2014/01/29 10:44:23, karlklose wrote: > ...

6 years, 10 months ago (2014-01-30 08:25:23 UTC) #3

Johnni Winther

Committed patchset #3 manually as r32154 (presubmit successful).

6 years, 10 months ago (2014-01-30 08:48:39 UTC) #4

Johnni Winther

6 years, 8 months ago (2014-04-09 11:15:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #6 manually as r34871 (presubmit successful).

Expand Messages | Collapse Messages