Issue 14672035: Further improve and simplify IL for building constructor type arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14672035: Further improve and simplify IL for building constructor type arguments. (Closed)

Created:
7 years, 7 months ago by Florian Schneider

Modified:
7 years, 7 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Further improve and simplify IL for building constructor type arguments. Generate constants in the IL directly if possible and avoid temporary local store/load completely in some cases. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=22931

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -177 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1	2 chunks	+28 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	2 chunks	+34 lines, -40 lines	1 comment	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	2 chunks	+36 lines, -42 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1	2 chunks	+33 lines, -39 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	2 chunks	+36 lines, -42 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

On 2013/05/21 09:49:52, Florian Schneider wrote: This is an incremental step. I'm planning to eliminate ...

7 years, 7 months ago (2013-05-21 10:36:04 UTC) #2

Kevin Millikin (Google)

LGTM. https://codereview.chromium.org/14672035/diff/7001/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (left): https://codereview.chromium.org/14672035/diff/7001/runtime/vm/intermediate_language_arm.cc#oldcode1662 runtime/vm/intermediate_language_arm.cc:1662: __ LoadImmediate(instantiator_reg, Yeah, this is kind of broken.

7 years, 7 months ago (2013-05-21 11:06:05 UTC) #3

Florian Schneider

7 years, 7 months ago (2013-05-21 11:09:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22931 (presubmit successful).

Expand Messages | Collapse Messages