Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 146693014: Add some additional debugging prints to the mac os watcher. (Closed)

Created:
6 years, 10 months ago by nweiz
Modified:
6 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add some additional debugging prints to the mac os watcher. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=32139

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/watcher/lib/src/directory_watcher/mac_os.dart View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
This test had a weird failure recently (http://build.chromium.org/p/client.dart/builders/vm-mac-debug-be/builds/1329/steps/tests/logs/stdio) and the added debugging should help track ...
6 years, 10 months ago (2014-01-29 01:05:28 UTC) #1
Bob Nystrom
Nit but LGTM. https://codereview.chromium.org/146693014/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart File pkg/watcher/lib/src/directory_watcher/mac_os.dart (right): https://codereview.chromium.org/146693014/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart#newcode473 pkg/watcher/lib/src/directory_watcher/mac_os.dart:473: new Chain.forTrace(stackTrace).terse.toString()); Nit, but I'd prefer ...
6 years, 10 months ago (2014-01-29 17:09:53 UTC) #2
nweiz
https://codereview.chromium.org/146693014/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart File pkg/watcher/lib/src/directory_watcher/mac_os.dart (right): https://codereview.chromium.org/146693014/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart#newcode473 pkg/watcher/lib/src/directory_watcher/mac_os.dart:473: new Chain.forTrace(stackTrace).terse.toString()); On 2014/01/29 17:09:53, Bob Nystrom wrote: > ...
6 years, 10 months ago (2014-01-29 21:06:40 UTC) #3
nweiz
6 years, 10 months ago (2014-01-29 21:07:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r32139 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698