Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 14660011: Add support for digest authentication of HTTP proxies (Closed)

Created:
7 years, 7 months ago by Søren Gjesse
Modified:
7 years, 7 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add support for digest authentication of HTTP proxies R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22460

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -46 lines) Patch
M sdk/lib/io/http_impl.dart View 9 chunks +59 lines, -18 lines 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 1 10 chunks +151 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 7 months ago (2013-05-07 13:18:24 UTC) #1
Anders Johnsen
LGTM, but, as discussed offline, maybe do a follow-up CL with a merge of normal- ...
7 years, 7 months ago (2013-05-07 13:23:58 UTC) #2
Søren Gjesse
7 years, 7 months ago (2013-05-07 13:59:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698