Issue 14660009: Implement support for application/x-www-form-urlencoded' form data in HttpBodyHandler.

Issue 14660009: Implement support for application/x-www-form-urlencoded' form data in HttpBodyHandler. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement support for application/x-www-form-urlencoded' form data in HttpBodyHandler. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22461

Patch Set 2 : Cleanup #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -4 lines)			Patch
M	sdk/lib/io/http_body_impl.dart	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	sdk/lib/io/http_multipart_form_data_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/http_utils.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/io/http_body_test.dart	View		2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/14660009/diff/1/sdk/lib/io/http_body_impl.dart File sdk/lib/io/http_body_impl.dart (right): https://codereview.chromium.org/14660009/diff/1/sdk/lib/io/http_body_impl.dart#newcode114 sdk/lib/io/http_body_impl.dart:114: return asText(Encoding.UTF_8) This might as well be ASCII, ...

7 years, 7 months ago (2013-05-07 13:39:29 UTC) #2

Anders Johnsen

https://codereview.chromium.org/14660009/diff/1/sdk/lib/io/http_body_impl.dart File sdk/lib/io/http_body_impl.dart (right): https://codereview.chromium.org/14660009/diff/1/sdk/lib/io/http_body_impl.dart#newcode114 sdk/lib/io/http_body_impl.dart:114: return asText(Encoding.UTF_8) On 2013/05/07 13:39:29, Søren Gjesse wrote: > ...

7 years, 7 months ago (2013-05-07 14:04:30 UTC) #3

Anders Johnsen

7 years, 7 months ago (2013-05-07 14:05:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22461 (presubmit successful).

Expand Messages | Collapse Messages