Issue 14655016: Report CompileTimeErrorCode.MIXIN_DECLARES_CONSTRUCTOR

Issue 14655016: Report CompileTimeErrorCode.MIXIN_DECLARES_CONSTRUCTOR (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report CompileTimeErrorCode.MIXIN_DECLARES_CONSTRUCTOR R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22549

Patch Set 2 : Fix for review comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -42 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	5 chunks	+55 lines, -20 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1	1 chunk	+31 lines, -9 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/14655016/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/14655016/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode1427 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:1427: private boolean checkForMixinDeclaresConstructor(ClassDeclaration node) { This and the ...

7 years, 7 months ago (2013-05-09 13:48:02 UTC) #2

scheglov

7 years, 7 months ago (2013-05-09 15:48:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22549 (presubmit successful).

Expand Messages | Collapse Messages