Issue 1465403002: Revert "Add RunnerSuite.{on,is}Debugging properties."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1465403002: Revert "Add RunnerSuite.{on,is}Debugging properties." (Closed)

Created:
5 years, 1 month ago by nweiz

Modified:
5 years, 1 month ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Add RunnerSuite.{on,is}Debugging properties." This reverts commit 71bfbdcd1b89ab62df9bf3a1a6f48bffe8c63974. This commit was causing intermittent stack overflows after running tests. I'm reverting so we can get 0.12.6 out immediately; I'll re-apply once I have time to fix the issues. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/8833887b99b28d328663dc595c3a7a300513b104

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -263 lines)			Patch
M	lib/src/runner/browser/browser_manager.dart	View	3 chunks	+86 lines, -10 lines	0 comments	Download
M	lib/src/runner/browser/iframe_listener.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	lib/src/runner/browser/suite.dart	View	1 chunk	+0 lines, -166 lines	0 comments	Download
M	lib/src/runner/load_suite.dart	View	5 chunks	+3 lines, -10 lines	0 comments	Download
M	lib/src/runner/runner_suite.dart	View	1 chunk	+15 lines, -72 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

5 years, 1 month ago (2015-11-24 05:31:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8833887b99b28d328663dc595c3a7a300513b104 (presubmit successful).

Expand Messages | Collapse Messages