Issue 14651019: Changing metadata lookup to always use interface.id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14651019: Changing metadata lookup to always use interface.id (Closed)

Created:
7 years, 7 months ago by blois

Modified:
7 years, 7 months ago

Reviewers:
Andrei Mouravski, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Changing metadata lookup to always use interface.id We had some discrepancies where interface lookup was using interface.doc_js_name but member lookup was using interface.id. Standardized on interface.id. Also updated the @DomName annotation to always use the JS interface name, which should help with MDN fallback documentation. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=22556

Patch Set 1 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+518 lines, -521 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	28 chunks	+239 lines, -242 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	24 chunks	+250 lines, -253 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	9 chunks	+23 lines, -20 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 7 months ago (2013-05-09 18:41:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22556 (presubmit successful).

Expand Messages | Collapse Messages