Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 14651005: Enable all vm tests on simarm (skip 2 timing out byte array tests). (Closed)

Created:
7 years, 7 months ago by regis
Modified:
7 years, 7 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enable all vm tests on simarm (skip 2 timing out byte array tests). Reduce number of iterations in inline_stack_frame_test to avoid time out. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=22280

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M runtime/tests/vm/dart/inline_stack_frame_test.dart View 1 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
regis
7 years, 7 months ago (2013-04-30 16:58:33 UTC) #1
siva
DBC https://codereview.chromium.org/14651005/diff/1/runtime/tests/vm/dart/inline_stack_frame_test.dart File runtime/tests/vm/dart/inline_stack_frame_test.dart (right): https://codereview.chromium.org/14651005/diff/1/runtime/tests/vm/dart/inline_stack_frame_test.dart#newcode69 runtime/tests/vm/dart/inline_stack_frame_test.dart:69: } Maybe add // VMOptions=--optimization_counter_threshold=10 to the top ...
7 years, 7 months ago (2013-04-30 17:24:21 UTC) #2
zra
lgtm with Siva's suggestions. https://codereview.chromium.org/14651005/diff/1/runtime/tests/vm/dart/inline_stack_frame_test.dart File runtime/tests/vm/dart/inline_stack_frame_test.dart (right): https://codereview.chromium.org/14651005/diff/1/runtime/tests/vm/dart/inline_stack_frame_test.dart#newcode69 runtime/tests/vm/dart/inline_stack_frame_test.dart:69: } On 2013/04/30 17:24:21, siva ...
7 years, 7 months ago (2013-04-30 18:01:39 UTC) #3
regis
Thanks both! After adding the optimization counter flag to inline_stack_frame_test, the code started to optimize/deoptimize, ...
7 years, 7 months ago (2013-05-01 21:09:46 UTC) #4
regis
7 years, 7 months ago (2013-05-01 21:10:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r22280 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698