Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 14647003: Be lazier when capturing stack traces. (Closed)

Created:
7 years, 7 months ago by nweiz
Modified:
7 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Be lazier when capturing stack traces. It turns out that capturing stack traces is cheap; converting them to strings is what's so expensive. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=22205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
A pkg/stack_trace/lib/src/lazy_trace.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M pkg/stack_trace/lib/src/trace.dart View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 7 months ago (2013-04-30 21:08:01 UTC) #1
Bob Nystrom
LGTM. Do you plan to remove the code from pub/scheduled_test that disables stack trace collection? ...
7 years, 7 months ago (2013-04-30 21:15:05 UTC) #2
nweiz
On 2013/04/30 21:15:05, Bob Nystrom wrote: > Do you plan to remove the code from ...
7 years, 7 months ago (2013-04-30 21:25:43 UTC) #3
nweiz
7 years, 7 months ago (2013-04-30 21:34:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22205 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698