Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 14646032: Fixing Location.origin to work on non-WebKit browsers. (Closed)

Created:
7 years, 7 months ago by blois
Modified:
7 years, 7 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing Location.origin to work on non-WebKit browsers. BUG=10162 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=22486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -10 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +16 lines, -6 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/html/location_test.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/src/dart2js_LocationWrapper.dart View 1 chunk +6 lines, -1 line 0 comments Download
A tools/dom/templates/html/impl/impl_Location.darttemplate View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 7 months ago (2013-05-07 23:41:35 UTC) #1
Emily Fortuna
lgtm
7 years, 7 months ago (2013-05-07 23:48:00 UTC) #2
blois
7 years, 7 months ago (2013-05-08 00:08:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698