Issue 14645025: Resubmit 22380 after fixing the windows build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14645025: Resubmit 22380 after fixing the windows build. (Closed)

Created:
7 years, 7 months ago by siva

Modified:
7 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Resubmit 22380 after fixing the windows build. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=22396

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+389 lines, -490 lines)			Patch
M	runtime/bin/dartutils.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	4 chunks	+57 lines, -20 lines	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/bin/main.cc	View	2 chunks	+4 lines, -21 lines	0 comments	Download
M	runtime/bin/run_vm_tests.cc	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/include/dart_api.h	View	2 chunks	+33 lines, -1 line	0 comments	Download
A +	runtime/lib/corelib_sources.gypi	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	runtime/lib/lib_sources.gypi	View	1 chunk	+0 lines, -57 lines	0 comments	Download
A +	runtime/lib/libgen_in.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	runtime/tools/gen_library_src_paths.py	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	runtime/vm/bootstrap.h	View	1 chunk	+15 lines, -12 lines	0 comments	Download
M	runtime/vm/bootstrap.cc	View	6 chunks	+138 lines, -51 lines	0 comments	Download
M	runtime/vm/dart.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/isolate.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/os_android.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/os_linux.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/vm.gypi	View	24 chunks	+101 lines, -315 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

7 years, 7 months ago (2013-05-03 22:50:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22396 (presubmit successful).

Expand Messages | Collapse Messages