Fix pub after changing the HttpServer.bind signature

Fix pub after changing the HttpServer.bind signature

R=ajohnsen@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=22234

[Søren Gjesse, 2013-05-01 10:12:19]

My local "testmost" script did not run pub :-(

[Anders Johnsen, 2013-05-01 10:13:09]

LGTM!

[Søren Gjesse, 2013-05-01 10:14:59]

Committed patchset #1 manually as r22234 (presubmit successful).

[Bob Nystrom, 2013-05-01 16:03:17]

https://codereview.chromium.org/14645013/diff/1/pkg/scheduled_test/lib/src/ut...
File pkg/scheduled_test/lib/src/utils.dart (right):

https://codereview.chromium.org/14645013/diff/1/pkg/scheduled_test/lib/src/ut...
pkg/scheduled_test/lib/src/utils.dart:38: if (text == null) return '';
Why is this change needed?

[Søren Gjesse, 2013-05-01 17:38:35]

https://codereview.chromium.org/14645013/diff/1/pkg/scheduled_test/lib/src/ut...
File pkg/scheduled_test/lib/src/utils.dart (right):

https://codereview.chromium.org/14645013/diff/1/pkg/scheduled_test/lib/src/ut...
pkg/scheduled_test/lib/src/utils.dart:38: if (text == null) return '';
On 2013/05/01 16:03:17, Bob Nystrom wrote:
> Why is this change needed?

I got an exception that text was null, which was hiding the actual error
backtrace/printout. With this change I got the real error output and was able to
find the actual error.

[nweiz, 2013-05-06 17:19:47]

https://codereview.chromium.org/14645013/diff/1/pkg/scheduled_test/lib/src/ut...
File pkg/scheduled_test/lib/src/utils.dart (right):

https://codereview.chromium.org/14645013/diff/1/pkg/scheduled_test/lib/src/ut...
pkg/scheduled_test/lib/src/utils.dart:38: if (text == null) return '';
On 2013/05/01 17:38:35, Søren Gjesse wrote:
> On 2013/05/01 16:03:17, Bob Nystrom wrote:
> > Why is this change needed?
> 
> I got an exception that text was null, which was hiding the actual error
> backtrace/printout. With this change I got the real error output and was able
to
> find the actual error.

[prefixLines] shouldn't do manual null-checking (any more than other methods
that take strings do). It's the caller's responsibility to make the string
null-safe. Where was this being called with a null input?

[Søren Gjesse, 2013-05-13 13:10:57]

https://codereview.chromium.org/14645013/diff/1/pkg/scheduled_test/lib/src/ut...
File pkg/scheduled_test/lib/src/utils.dart (right):

https://codereview.chromium.org/14645013/diff/1/pkg/scheduled_test/lib/src/ut...
pkg/scheduled_test/lib/src/utils.dart:38: if (text == null) return '';
If you undo this change and the change to
sdk/lib/_internal/pub/lib/src/safe_http_server.dart from this cl, and then run
the pub tests you get errors like below.

FAILED: none-vm release_ia32 pub/test/install/hosted/install_test
Expected: pass 
Actual: fail

stdout:
✗ installs a package from a pub server
  Caught The null object does not have a method 'split'.
  
  NoSuchMethodError : method not found: 'split'
  Receiver: null
  Arguments: ["\n"]

✗ URL encodes the package name
  Caught Bad state: There seems to be another scheduled test still running.



stderr:
Unhandled exception:
FormatException: Couldn't parse stack trace line '_setUpScheduledTest.<anonymous
closure>   package:scheduled_test/scheduled_test.dart 319:9'.
#0      _StackFrame._StackFrame
(file:///usr/local/prj/dart/git/dart/sdk/lib/_internal/pub/test/command_line_config.dart:157:9)
#1      CommandLineConfiguration._printStackTrace
(file:///usr/local/prj/dart/git/dart/sdk/lib/_internal/pub/test/command_line_config.dart:89:17)
#2      CommandLineConfiguration.onTestResult
(file:///usr/local/prj/dart/git/dart/sdk/lib/_internal/pub/test/command_line_config.dart:52:21)
#3      TestCase._setResult (package:unittest/src/test_case.dart:155:27)
#4      TestCase._complete (package:unittest/src/test_case.dart:174:15)
#5      TestCase.fail (package:unittest/src/test_case.dart:211:16)
#6      _registerException (package:unittest/unittest.dart:757:18)
#7      _guardAsync (package:unittest/unittest.dart:737:23)
#8      _nextBatch (package:unittest/unittest.dart:775:24)
#9      _nextTestCase.<anonymous closure>
(package:unittest/unittest.dart:669:15)
#10     _asyncRunCallback._asyncRunCallback (dart:async/event_loop.dart:15:17)
#11     _asyncRunCallback._asyncRunCallback (dart:async/event_loop.dart:25:9)
#12     Timer.run.<anonymous closure> (dart:async/timer.dart:17:21)
#13     Timer.run.<anonymous closure> (dart:async/timer.dart:25:13)
#14     Timer.Timer.<anonymous closure> (dart:async-patch/timer_patch.dart:9:15)
#15     _Timer._createTimerHandler._handleTimeout (dart:io:7177:28)
#16     _Timer._createTimerHandler._handleTimeout (dart:io:7185:7)
#17     _Timer._createTimerHandler.<anonymous closure> (dart:io:7193:23)
#18     _ReceivePortImpl._handleMessage
(dart:isolate-patch/isolate_patch.dart:81:92)


Command line: out/ReleaseIA32/dart-sdk/bin/dart "--ignore-unrecognized-flags"
"--package-root=out/ReleaseIA32/packages/"
"/usr/local/prj/dart/git/dart/sdk/lib/_internal/pub/test/install/hosted/install_test.dart"

On 2013/05/06 17:19:47, nweiz wrote:
> On 2013/05/01 17:38:35, Søren Gjesse wrote:
> > On 2013/05/01 16:03:17, Bob Nystrom wrote:
> > > Why is this change needed?
> > 
> > I got an exception that text was null, which was hiding the actual error
> > backtrace/printout. With this change I got the real error output and was
able
> to
> > find the actual error.
> 
> [prefixLines] shouldn't do manual null-checking (any more than other methods
> that take strings do). It's the caller's responsibility to make the string
> null-safe. Where was this being called with a null input?