Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 14645003: Fix csp flags send to browsers. (Closed)

Created:
7 years, 7 months ago by ricow1
Modified:
7 years, 7 months ago
Reviewers:
kasperl, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix csp flags send to browsers. We can't send the webkit flag to chrome, it will throw an error. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=22178

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M tools/test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/http_server.dart View 1 5 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
7 years, 7 months ago (2013-04-30 11:33:40 UTC) #1
kustermann
lgtm https://codereview.chromium.org/14645003/diff/1/tools/testing/dart/http_server.dart File tools/testing/dart/http_server.dart (right): https://codereview.chromium.org/14645003/diff/1/tools/testing/dart/http_server.dart#newcode333 tools/testing/dart/http_server.dart:333: if (runtime == "safari") { Once we're doing ...
7 years, 7 months ago (2013-04-30 11:36:51 UTC) #2
ricow1
7 years, 7 months ago (2013-04-30 12:02:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698