Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 14637013: Fix ARM memory addressing mode 3 in assembler. (Closed)

Created:
7 years, 7 months ago by regis
Modified:
7 years, 7 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix ARM memory addressing mode 3 in assembler. Update assembler test. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=22285

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M runtime/vm/assembler_arm.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 7 months ago (2013-05-01 21:16:32 UTC) #1
zra
lgtm
7 years, 7 months ago (2013-05-01 21:31:47 UTC) #2
regis
7 years, 7 months ago (2013-05-01 21:33:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22285 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698