Issue 14634011: move top-level internal methods into a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14634011: move top-level internal methods into a class (Closed)

Created:
7 years, 7 months ago by Jennifer Messerly

Modified:
7 years, 7 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move top-level internal methods of the MDV system into a class. In dart:html we don't have the luxury of sublibraries, so we resort to the static-methods pattern to emulate a namespace. If there was a more appropriate class I put it there, but some methods are shared by multiple other classes. Note, this uses another CL (https://codereview.chromium.org/14795005) as its baseline. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=22654

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+818 lines, -815 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 2 3	14 chunks	+272 lines, -271 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		14 chunks	+272 lines, -271 lines	0 comments	Download
M	tools/dom/src/TemplateBindings.dart	View		8 chunks	+266 lines, -265 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate	View	1 2 3	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm! (and thanks, should have caught this on the earlier CL)

7 years, 7 months ago (2013-05-13 20:25:50 UTC) #2

Jennifer Messerly

On 2013/05/13 20:25:50, blois wrote: > lgtm! (and thanks, should have caught this on the ...

7 years, 7 months ago (2013-05-13 20:26:32 UTC) #3

Jennifer Messerly

7 years, 7 months ago (2013-05-13 22:57:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r22654 (presubmit successful).

Expand Messages | Collapse Messages