Issue 14630016: Getting html_dart2js and html_dartium a bit more in sync.

Issue 14630016: Getting html_dart2js and html_dartium a bit more in sync. (Closed)

Created:
7 years, 7 months ago by blois

Modified:
7 years, 7 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Getting html_dart2js and html_dartium a bit more in sync. I used the analyzer and made a quick API diff app to compare the two libraries, most of these are just minor nits, but good to get them in sync. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=22963

Patch Set 1 : #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -44 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	8 chunks	+12 lines, -12 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	9 chunks	+12 lines, -10 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	4 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/src/dartium_KeyEvent.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/impl_Console.darttemplate	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/impl_URL.darttemplate	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+3 lines, -3 lines	2 comments	Download
M	tools/dom/templates/html/impl/impl_WheelEvent.darttemplate	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm https://codereview.chromium.org/14630016/diff/6001/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/14630016/diff/6001/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode556 tools/dom/templates/html/impl/impl_Element.darttemplate:556: void insertAdjacentHtml(String where, String html) { really? the ...

7 years, 7 months ago (2013-05-14 00:29:30 UTC) #2

blois

https://codereview.chromium.org/14630016/diff/6001/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/14630016/diff/6001/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode556 tools/dom/templates/html/impl/impl_Element.darttemplate:556: void insertAdjacentHtml(String where, String html) { On 2013/05/14 00:29:30, ...

7 years, 7 months ago (2013-05-14 01:03:16 UTC) #3

blois

7 years, 7 months ago (2013-05-21 21:52:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r22963 (presubmit successful).

Expand Messages | Collapse Messages