Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 14629015: Implement Smi.toString in Dart instead of calling to C++ natives. Large performance improvement. (Closed)

Created:
7 years, 7 months ago by srdjan
Modified:
7 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement Smi.toString in Dart instead of calling to C++ natives. Large performance improvement. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22341

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M runtime/lib/integers.dart View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
7 years, 7 months ago (2013-05-02 18:35:10 UTC) #1
siva
7 years, 7 months ago (2013-05-02 20:44:37 UTC) #2
siva
lgtm
7 years, 7 months ago (2013-05-02 20:44:43 UTC) #3
srdjan
7 years, 7 months ago (2013-05-02 21:40:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22341 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698