Issue 14623030: Detect dead code, and handle breaks and continues in inferrer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14623030: Detect dead code, and handle breaks and continues in inferrer. (Closed)

Created:
7 years, 7 months ago by ngeoffray

Modified:
7 years, 7 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Detect dead code, and handle breaks and continues in inferrer. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=22929

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+256 lines, -49 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+3 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1 2	12 chunks	+141 lines, -39 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_test.dart	View	1	4 chunks	+78 lines, -0 lines	0 comments	Download
A	tests/language/inferrer_constructor_test.dart	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

ngeoffray

Thanks Johnni. Could you please PTAL? I had to implement break and continue too, to ...

7 years, 7 months ago (2013-05-21 10:21:10 UTC) #3

ngeoffray

7 years, 7 months ago (2013-05-21 10:47:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r22929 (presubmit successful).