Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 14623015: Potentially fix the crash reported in Issue 10385 (Closed)

Created:
7 years, 7 months ago by siva
Modified:
7 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, john_johnmccutchan.com
Visibility:
Public.

Description

Potentially fix the crash reported in Issue 10385 - Fix use of a tagged pointer - Fix a memory leak R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -23 lines) Patch
M runtime/vm/heap_profiler.h View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/heap_profiler.cc View 4 chunks +9 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 7 months ago (2013-05-02 22:47:01 UTC) #1
srdjan
LGTM
7 years, 7 months ago (2013-05-02 22:58:35 UTC) #2
siva
7 years, 7 months ago (2013-05-02 23:10:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698