Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 14619027: Fix for issue 10534. Implement int.pow correctly. Note that int.pow is considerably slower than dou… (Closed)

Created:
7 years, 7 months ago by srdjan
Modified:
7 years, 7 months ago
Reviewers:
floitsch, siva
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Fix for issue 10534. Implement int.pow correctly using exponentiation by squaring. Note that int.pow is now considerably slower than double.pow. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=22635

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M runtime/lib/integers.dart View 1 2 3 1 chunk +10 lines, -5 lines 0 comments Download
M runtime/lib/math_patch.dart View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M tests/standalone/pow_test.dart View 1 2 3 1 chunk +11 lines, -2 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
7 years, 7 months ago (2013-05-10 00:29:05 UTC) #1
srdjan
7 years, 7 months ago (2013-05-13 16:01:59 UTC) #2
floitsch
LGTM.
7 years, 7 months ago (2013-05-13 17:22:36 UTC) #3
srdjan
7 years, 7 months ago (2013-05-13 17:42:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r22635 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698