Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 14619026: dart2js native mixin application should extend 'Interface', not 'Object' (Closed)

Created:
7 years, 7 months ago by sra1
Modified:
7 years, 7 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart2js native mixin application should extend 'Interface', not 'Object' R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=22602

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -35 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 20 chunks +20 lines, -19 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 8 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/html/node_test.dart View 1 1 chunk +59 lines, -6 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/svg_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sra1
7 years, 7 months ago (2013-05-10 00:24:33 UTC) #1
blois
lgtm https://codereview.chromium.org/14619026/diff/1/tests/html/node_test.dart File tests/html/node_test.dart (right): https://codereview.chromium.org/14619026/diff/1/tests/html/node_test.dart#newcode327 tests/html/node_test.dart:327: group('NodeList', () { Why not put it in ...
7 years, 7 months ago (2013-05-10 00:34:30 UTC) #2
sra1
https://codereview.chromium.org/14619026/diff/1/tests/html/node_test.dart File tests/html/node_test.dart (right): https://codereview.chromium.org/14619026/diff/1/tests/html/node_test.dart#newcode327 tests/html/node_test.dart:327: group('NodeList', () { On 2013/05/10 00:34:30, blois wrote: > ...
7 years, 7 months ago (2013-05-10 22:13:26 UTC) #3
sra1
7 years, 7 months ago (2013-05-10 22:14:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22602 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698