Explicitly implementing some DOM iterable APIs for performance

Explicitly implementing some DOM iterable APIs for performance

The move to mixins severely regressed dart2js DOM performance, this patches it some while work continues.
BUG=
R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22575

[blois, 2013-05-09 18:38:12]

Updated with using more native indexers, range checking & a test for NodeList
range checking.

[sra1, 2013-05-09 19:55:50]

lgtm

https://chromiumcodereview.appspot.com/14619013/diff/1015/sdk/lib/html/dartiu...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://chromiumcodereview.appspot.com/14619013/diff/1015/sdk/lib/html/dartiu...
sdk/lib/html/dartium/html_dartium.dart:7250: if (index < 0 || index >= length)
throw new RangeError.range(index, 0, length);
Do you know if the native indexer does a bounds check?
I would expect it does.

https://chromiumcodereview.appspot.com/14619013/diff/1015/tools/dom/scripts/s...
File tools/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/14619013/diff/1015/tools/dom/scripts/s...
tools/dom/scripts/systemhtml.py:714: indexed_getter = 'JS("%s", "#[#]", this,
index)' % self.SecureOutputType(element_type);
line length

https://chromiumcodereview.appspot.com/14619013/diff/1015/tools/dom/scripts/s...
File tools/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/14619013/diff/1015/tools/dom/scripts/s...
tools/dom/scripts/systemnative.py:431: '  $TYPE operator[](int index) {\n'
Does the native code to a bounds check?

https://chromiumcodereview.appspot.com/14619013/diff/1015/tools/dom/scripts/s...
tools/dom/scripts/systemnative.py:432: '    if (index < 0 || index >= length)
throw new RangeError.range(index, 0, length);\n'
line length

https://chromiumcodereview.appspot.com/14619013/diff/1015/tools/dom/templates...
File tools/dom/templates/immutable_list_mixin.darttemplate (right):

https://chromiumcodereview.appspot.com/14619013/diff/1015/tools/dom/templates...
tools/dom/templates/immutable_list_mixin.darttemplate:51: $E elementAt(int
index) {
nit: could be =>

[blois, 2013-05-09 20:00:25]

https://chromiumcodereview.appspot.com/14619013/diff/1015/sdk/lib/html/dartiu...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://chromiumcodereview.appspot.com/14619013/diff/1015/sdk/lib/html/dartiu...
sdk/lib/html/dartium/html_dartium.dart:7250: if (index < 0 || index >= length)
throw new RangeError.range(index, 0, length);
On 2013/05/09 19:55:50, sra1 wrote:
> Do you know if the native indexer does a bounds check?
> I would expect it does.

It does not throw an exception for out of bounds (the test I added to node_test
was failing without this).

https://chromiumcodereview.appspot.com/14619013/diff/1015/tools/dom/scripts/s...
File tools/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/14619013/diff/1015/tools/dom/scripts/s...
tools/dom/scripts/systemnative.py:431: '  $TYPE operator[](int index) {\n'
On 2013/05/09 19:55:50, sra1 wrote:
> Does the native code to a bounds check?

It appears to have the same behavior as JS.

[blois, 2013-05-09 22:49:24]

https://codereview.chromium.org/14619013/diff/1015/tools/dom/scripts/systemht...
File tools/dom/scripts/systemhtml.py (right):

https://codereview.chromium.org/14619013/diff/1015/tools/dom/scripts/systemht...
tools/dom/scripts/systemhtml.py:714: indexed_getter = 'JS("%s", "#[#]", this,
index)' % self.SecureOutputType(element_type);
On 2013/05/09 19:55:50, sra1 wrote:
> line length

Done.

https://codereview.chromium.org/14619013/diff/1015/tools/dom/scripts/systemna...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/14619013/diff/1015/tools/dom/scripts/systemna...
tools/dom/scripts/systemnative.py:432: '    if (index < 0 || index >= length)
throw new RangeError.range(index, 0, length);\n'
On 2013/05/09 19:55:50, sra1 wrote:
> line length

Done.

[blois, 2013-05-09 23:31:27]

Committed patchset #3 manually as r22575 (presubmit successful).