Add static getters for common internet addresses

Add static getters for common internet addresses

R=whesse@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=22174

[Bill Hesse, 2013-04-30 10:50:22]

LGTM, with comments.

https://codereview.chromium.org/14619008/diff/5001/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

https://codereview.chromium.org/14619008/diff/5001/runtime/bin/socket.cc#newc...
runtime/bin/socket.cc:73: UNREACHABLE();
Should we do slightly better error handling here, even though you only call this
from known functions, with good args?

https://codereview.chromium.org/14619008/diff/5001/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/14619008/diff/5001/runtime/bin/socket_patch.d...
runtime/bin/socket_patch.dart:70: switch (id) {
Maybe put var sockaddr = _fixed(id)
before the switch, and use it inside?

https://codereview.chromium.org/14619008/diff/5001/runtime/bin/socket_patch.d...
runtime/bin/socket_patch.dart:84: assert(false);
There is no return value for the function in the default case if asserts are
turned off.  Why not throw an exception?

https://codereview.chromium.org/14619008/diff/5001/sdk/lib/io/socket.dart
File sdk/lib/io/socket.dart (right):

https://codereview.chromium.org/14619008/diff/5001/sdk/lib/io/socket.dart#new...
sdk/lib/io/socket.dart:10: * IP version 4 and IP version 6 are supported.
Maybe say (IPv4) and (IPv6) in parentheses?  I have usually seen it written as
IPv4.

https://codereview.chromium.org/14619008/diff/5001/sdk/lib/io/socket.dart#new...
sdk/lib/io/socket.dart:45: * address, for wich a socket can be connected to or
bound on.
to which a socket can be connected or a listening socket bound.

But this isn't true - you need to specify an address and a port to connect or
bind a socket.

"... or a local address.  When combined with a port number, this represents a
endpoint that a socket can connect to or a listening socket can bind to."

https://codereview.chromium.org/14619008/diff/5001/sdk/lib/io/socket.dart#new...
sdk/lib/io/socket.dart:93: * performed, and can as such change over time.
I would remove "as such".  If necessary, say "therefore".  But I think neither
is needed.

https://codereview.chromium.org/14619008/diff/5001/tests/standalone/io/intern...
File tests/standalone/io/internet_address_test.dart (right):

https://codereview.chromium.org/14619008/diff/5001/tests/standalone/io/intern...
tests/standalone/io/internet_address_test.dart:14: Expect.equals("127.0.0.1",
loopback4.address);
There is something wrong with the fact that we can't test _sockaddr_storage,
because it is private.  But I can't think of a way around this, except putting
tests in the library, or making it public.

[Søren Gjesse, 2013-04-30 11:28:41]

https://codereview.chromium.org/14619008/diff/5001/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

https://codereview.chromium.org/14619008/diff/5001/runtime/bin/socket.cc#newc...
runtime/bin/socket.cc:73: UNREACHABLE();
On 2013/04/30 10:50:22, Bill Hesse wrote:
> Should we do slightly better error handling here, even though you only call
this
> from known functions, with good args?

Changed to throw ArgumentError.

https://codereview.chromium.org/14619008/diff/5001/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/14619008/diff/5001/runtime/bin/socket_patch.d...
runtime/bin/socket_patch.dart:70: switch (id) {
On 2013/04/30 10:50:22, Bill Hesse wrote:
> Maybe put var sockaddr = _fixed(id)
> before the switch, and use it inside?

Done.

https://codereview.chromium.org/14619008/diff/5001/runtime/bin/socket_patch.d...
runtime/bin/socket_patch.dart:84: assert(false);
On 2013/04/30 10:50:22, Bill Hesse wrote:
> There is no return value for the function in the default case if asserts are
> turned off.  Why not throw an exception?

Done.

https://codereview.chromium.org/14619008/diff/5001/sdk/lib/io/socket.dart
File sdk/lib/io/socket.dart (right):

https://codereview.chromium.org/14619008/diff/5001/sdk/lib/io/socket.dart#new...
sdk/lib/io/socket.dart:10: * IP version 4 and IP version 6 are supported.
On 2013/04/30 10:50:22, Bill Hesse wrote:
> Maybe say (IPv4) and (IPv6) in parentheses?  I have usually seen it written as
> IPv4.

Done.

https://codereview.chromium.org/14619008/diff/5001/sdk/lib/io/socket.dart#new...
sdk/lib/io/socket.dart:45: * address, for wich a socket can be connected to or
bound on.
On 2013/04/30 10:50:22, Bill Hesse wrote:
> to which a socket can be connected or a listening socket bound.
> 
> But this isn't true - you need to specify an address and a port to connect or
> bind a socket.
> 
> "... or a local address.  When combined with a port number, this represents a
> endpoint that a socket can connect to or a listening socket can bind to."  

Done.

https://codereview.chromium.org/14619008/diff/5001/sdk/lib/io/socket.dart#new...
sdk/lib/io/socket.dart:93: * performed, and can as such change over time.
On 2013/04/30 10:50:22, Bill Hesse wrote:
> I would remove "as such".  If necessary, say "therefore".  But I think neither
> is needed.

Done.

https://codereview.chromium.org/14619008/diff/5001/tests/standalone/io/intern...
File tests/standalone/io/internet_address_test.dart (right):

https://codereview.chromium.org/14619008/diff/5001/tests/standalone/io/intern...
tests/standalone/io/internet_address_test.dart:14: Expect.equals("127.0.0.1",
loopback4.address);
On 2013/04/30 10:50:22, Bill Hesse wrote:
> There is something wrong with the fact that we can't test _sockaddr_storage,
> because it is private.  But I can't think of a way around this, except putting
> tests in the library, or making it public.

Yes, that's true. The content of _sockaddr_storage is also platform specific as
on Mac there is a length field first which is not on the other platforms. I did
a local test with printing the bytes - and it looks right.

[Søren Gjesse, 2013-04-30 11:30:16]

Committed patchset #4 manually as r22174 (presubmit successful).