Chromium Code Reviews

Issue 1461293005: Add a JSON reporter. (Closed)

Created:
5 years, 1 month ago by nweiz
Modified:
5 years, 1 month ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org, messick
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Stats (+1028 lines, -86 lines)
A json_reporter.md View 1 chunk +246 lines, -0 lines 0 comments
A json_reporter.schema.json View 1 chunk +106 lines, -0 lines 2 comments
M lib/src/executable.dart View 3 chunks +5 lines, -59 lines 0 comments
M lib/src/runner.dart View 2 chunks +23 lines, -11 lines 0 comments
M lib/src/runner/configuration.dart View 1 chunk +3 lines, -2 lines 0 comments
A lib/src/runner/reporter/json.dart View 1 chunk +168 lines, -0 lines 0 comments
A lib/src/runner/version.dart View 1 chunk +61 lines, -0 lines 0 comments
M test/io.dart View 1 chunk +6 lines, -7 lines 0 comments
M test/runner/browser/compact_reporter_test.dart View 1 chunk +1 line, -2 lines 0 comments
M test/runner/compact_reporter_test.dart View 3 chunks +3 lines, -3 lines 0 comments
M test/runner/expanded_reporter_test.dart View 2 chunks +2 lines, -2 lines 0 comments
A test/runner/json_reporter_test.dart View 1 chunk +404 lines, -0 lines 2 comments

Messages

Total messages: 5 (1 generated)
nweiz
The tests aren't quite finished, but otherwise this is pretty much done.
5 years, 1 month ago (2015-11-21 02:54:48 UTC) #2
kevmoo
Code looks solid. Add notes to readme about the new feature I'd love to see ...
5 years, 1 month ago (2015-11-21 03:37:18 UTC) #3
nweiz
> Add notes to readme about the new feature I assume you mean the changelog? ...
5 years, 1 month ago (2015-11-23 22:24:08 UTC) #4
nweiz
5 years, 1 month ago (2015-11-23 22:24:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3d6797dc64c33fad9c73b958c8f1ad32e243da2d (presubmit successful).

Powered by Google App Engine