Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 14611007: Don't use length when reading a file in chunks (but continue to EOF). (Closed)

Created:
7 years, 7 months ago by Anders Johnsen
Modified:
7 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't use length when reading a file in chunks (but continue to EOF). BUG=http://code.google.com/p/dart/issues/detail?id=10381 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M sdk/lib/io/file_impl.dart View 1 chunk +4 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 7 months ago (2013-05-02 11:40:31 UTC) #1
Søren Gjesse
lgtm
7 years, 7 months ago (2013-05-02 11:42:19 UTC) #2
Anders Johnsen
7 years, 7 months ago (2013-05-02 11:42:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22314 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698