Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 145973005: Change Rectangle.operator== to compare right/bottom instead of width/height. (Closed)

Created:
6 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change Rectangle.operator== to compare right/bottom instead of width/height. BUG= http://dartbug.com/16245 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=32155

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M sdk/lib/math/rectangle.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/lib/math/rectangle_test.dart View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lasse Reichstein Nielsen
6 years, 10 months ago (2014-01-29 09:38:52 UTC) #1
Lasse Reichstein Nielsen
6 years, 10 months ago (2014-01-29 09:38:53 UTC) #2
Emily Fortuna
why this change though? This just adds another operation (+) to access right and bottom ...
6 years, 10 months ago (2014-01-29 19:03:51 UTC) #3
Emily Fortuna
lgtm. saw your explanation in the other email.
6 years, 10 months ago (2014-01-29 22:42:20 UTC) #4
Lasse Reichstein Nielsen
Let's just repeat it here, for posterity. A rectangle represents the points that are between ...
6 years, 10 months ago (2014-01-30 09:53:39 UTC) #5
Lasse Reichstein Nielsen
6 years, 10 months ago (2014-01-30 09:54:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r32155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698