Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 145953006: Remove workaround for missing setter function returns (dartbug.com/15914). (Closed)

Created:
6 years, 10 months ago by pquitslund
Modified:
6 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove workaround for missing setter function returns (dartbug.com/15914). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=32091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 1 chunk +1 line, -10 lines 0 comments Download
M pkg/analyzer/test/services/data/cu_tests.data View 2 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
6 years, 10 months ago (2014-01-28 22:37:33 UTC) #1
Brian Wilkerson
LGTM
6 years, 10 months ago (2014-01-28 22:50:33 UTC) #2
pquitslund
6 years, 10 months ago (2014-01-28 22:51:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698