Issue 14595006: Extend HTTP digest support with server changing nonce

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14595006: Extend HTTP digest support with server changing nonce (Closed)

Created:
7 years, 7 months ago by Søren Gjesse

Modified:
7 years, 7 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Extend HTTP digest support with server changing nonce Support the server changing nonce. Supportts Both a server sending a new 401 response with stale=true in the WWW-Authenticate response header and a server using nextnonce in the Authentication-Info response header. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22369

Patch Set 1 #

Patch Set 2 : Minor fix #

Patch Set 3 : Minor fix #

Total comments: 1

Patch Set 4 : Minor fixes #

Patch Set 5 : Addressed review comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -25 lines)			Patch
	M	sdk/lib/io/http_impl.dart	View	1 2 3	4 chunks	+30 lines, -11 lines	0 comments	Download
	M	tests/standalone/io/http_auth_digest_test.dart	View	1 2 3 4	10 chunks	+110 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM :) I'm impressed of how little code we have to change, to get stuff ...

7 years, 7 months ago (2013-05-03 12:07:35 UTC) #2

Søren Gjesse

7 years, 7 months ago (2013-05-03 13:10:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r22369 (presubmit successful).

Expand Messages | Collapse Messages