Issue 14593010: Log verbose output when testing pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14593010: Log verbose output when testing pub. (Closed)

Created:
7 years, 7 months ago by nweiz

Modified:
7 years, 7 months ago

Reviewers:
blois

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Log verbose output when testing pub. This involves creating a subclass of ScheduledProcess that takes the verbose output and transforms it back into normal, non-verbose output. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=22708

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+148 lines, -25 lines)			Patch
M	pkg/scheduled_test/lib/scheduled_process.dart	View	3 chunks	+32 lines, -7 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/utils.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/io.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/utils.dart	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/lish/archives_and_uploads_a_package_test.dart	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/oauth2/utils.dart	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/test_pub.dart	View	4 chunks	+84 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

blois

lgtm, though I'm not too familiar with pub & scheduled_test. Might be good to get ...

7 years, 7 months ago (2013-05-14 21:35:45 UTC) #2

nweiz

7 years, 7 months ago (2013-05-14 21:44:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22708 (presubmit successful).