Issue 14593004: Fix dartbug.com/10415:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14593004: Fix dartbug.com/10415: (Closed)

Created:
7 years, 7 months ago by Ivan Posva

Modified:
7 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix dartbug.com/10415: - Append 'on "$os_$arch"' to the version string on the VM. Committed: https://code.google.com/p/dart/source/detail?r=22452

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -3 lines)			Patch
M	runtime/vm/cpu_arm.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/vm/cpu_mips.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/vm/cpu_test.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/os.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/os_android.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/os_linux.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/os_macos.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/os_win.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/version_in.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Ivan Posva

Now prints when running the MIPS simulator on Mac OS X: Dart VM version: 0.1.2.0_r22412_iposva ...

7 years, 7 months ago (2013-05-07 07:57:53 UTC) #1

Ivan Posva

7 years, 7 months ago (2013-05-07 07:59:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22452 (presubmit successful).