Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 14590002: Removing PagePopupController. (Closed)

Created:
7 years, 7 months ago by blois
Modified:
7 years, 7 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removing PagePopupController. BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=22162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -86 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +9 lines, -41 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +13 lines, -45 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 7 months ago (2013-04-30 02:10:46 UTC) #1
Jacob
On 2013/04/30 02:10:46, blois wrote: This was crashing Dartium and did nothing in Dart2Js. Thanks ...
7 years, 7 months ago (2013-04-30 02:12:09 UTC) #2
blois
7 years, 7 months ago (2013-04-30 02:13:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22162 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698