Issue 14589014: Change async read buffer sizes on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14589014: Change async read buffer sizes on Windows (Closed)

Created:
7 years, 7 months ago by Søren Gjesse

Modified:
7 years, 7 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change async read buffer sizes on Windows When reading from the console using ReadFile on Windows the buffer size must be a bit smaller than 32k. Use a 16k buffer in that case and raise the buffer size to 64k otherwise. R=ajohnsen@google.com BUG=https://code.google.com/p/dart/issues/detail?id=9429 Committed: https://code.google.com/p/dart/source/detail?r=22411

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	runtime/bin/eventhandler_win.cc	View		2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

7 years, 7 months ago (2013-05-06 12:28:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22411 (presubmit successful).

Expand Messages | Collapse Messages