Issue 14586004: Fix listing directories with recursive symlinks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14586004: Fix listing directories with recursive symlinks. (Closed)

Created:
7 years, 7 months ago by Bob Nystrom

Modified:
7 years, 7 months ago

Reviewers:
Andrei Mouravski

CC:
reviews_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix listing directories with recursive symlinks. BUG=https://code.google.com/p/dart/issues/detail?id=7505 R=amouravski@google.com Committed: https://code.google.com/p/dart/source/detail?r=22295

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/io.dart	View		3 chunks	+15 lines, -13 lines	2 comments	Download
	M	sdk/lib/_internal/pub/pub.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

lgtm 1 comment. https://codereview.chromium.org/14586004/diff/1/sdk/lib/_internal/pub/lib/src/io.dart File sdk/lib/_internal/pub/lib/src/io.dart (right): https://codereview.chromium.org/14586004/diff/1/sdk/lib/_internal/pub/lib/src/io.dart#newcode141 sdk/lib/_internal/pub/lib/src/io.dart:141: var children = <String>[]; Why not ...

7 years, 7 months ago (2013-05-02 00:16:13 UTC) #2

Bob Nystrom

Thanks! https://codereview.chromium.org/14586004/diff/1/sdk/lib/_internal/pub/lib/src/io.dart File sdk/lib/_internal/pub/lib/src/io.dart (right): https://codereview.chromium.org/14586004/diff/1/sdk/lib/_internal/pub/lib/src/io.dart#newcode141 sdk/lib/_internal/pub/lib/src/io.dart:141: var children = <String>[]; On 2013/05/02 00:16:13, Andrei ...

7 years, 7 months ago (2013-05-02 00:18:59 UTC) #3

Bob Nystrom

7 years, 7 months ago (2013-05-02 00:19:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22295 (presubmit successful).

Expand Messages | Collapse Messages