Issue 14580013: Close stdout and stderr before terminating the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14580013: Close stdout and stderr before terminating the VM. (Closed)

Created:
7 years, 7 months ago by podivilov

Modified:
7 years, 7 months ago

Reviewers:
Siggi Cherem (dart-lang), gram

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Close stdout and stderr before terminating the VM. Otherwise stdout and stderr output is swallowed on async unhandled exceptions. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=22623

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : l #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	pkg/unittest/lib/vm_config.dart	View	1 2	2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/14580013/diff/2001/pkg/unittest/lib/vm_config.dart File pkg/unittest/lib/vm_config.dart (right): https://codereview.chromium.org/14580013/diff/2001/pkg/unittest/lib/vm_config.dart#newcode18 pkg/unittest/lib/vm_config.dart:18: exit(0); do you need to wait here too?

7 years, 7 months ago (2013-05-07 17:47:48 UTC) #2

podivilov

ptal https://codereview.chromium.org/14580013/diff/2001/pkg/unittest/lib/vm_config.dart File pkg/unittest/lib/vm_config.dart (right): https://codereview.chromium.org/14580013/diff/2001/pkg/unittest/lib/vm_config.dart#newcode18 pkg/unittest/lib/vm_config.dart:18: exit(0); On 2013/05/07 17:47:48, Siggi Cherem (dart-lang) wrote: ...

7 years, 7 months ago (2013-05-08 12:42:44 UTC) #3

podivilov

7 years, 7 months ago (2013-05-13 13:40:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r22623 (presubmit successful).

Expand Messages | Collapse Messages