Add a DateTimeRule to default serialization

Add a DateTimeRule to default serialization

R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22750

[Alan Knight, 2013-05-14 20:39:34]

The DateTime class is a bit awkward to serialize since they changed it to have
separate constructors for utc and local. This adds a rule for it to the
defaults. Since it's written as a custom rule, it also generalizes the detection
of selfDescribing to not hard-code a check for CustomRule, but rather to look
for rules that it doesn't know how to meta-serialize. Also fixed the date test
that was there to be round-trip, which it wasn't before, and would have failed
if it was.

[Jennifer Messerly, 2013-05-14 23:18:33]

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/lib/seriali...
File pkg/serialization/lib/serialization.dart (right):

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/lib/seriali...
pkg/serialization/lib/serialization.dart:403: Iterable<SerializationRule>
rulesFor(object, Writer w, [create = true]) {
consider: named argument here, they tend to be a bit more descriptive for
booleans.

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/lib/src/ser...
File pkg/serialization/lib/src/serialization_rule.dart (right):

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/lib/src/ser...
pkg/serialization/lib/src/serialization_rule.dart:507: [date.year, date.month,
date.day, date.hour, date.minute,
alternatively, just store millisecondsSinceEpoch and isUtc?

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/lib/src/ser...
pkg/serialization/lib/src/serialization_rule.dart:512: return
Function.apply(creation, state.take(7).toList());
TIL: we have Function.apply :)

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/test/serial...
File pkg/serialization/test/serialization_test.dart (right):

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/test/serial...
pkg/serialization/test/serialization_test.dart:147: var utcDate = new
DateTime.utc(date.year, date.month, date.day,
date.toUtc() ?

[Alan Knight, 2013-05-14 23:32:55]

PTAL

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/lib/seriali...
File pkg/serialization/lib/serialization.dart (right):

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/lib/seriali...
pkg/serialization/lib/serialization.dart:403: Iterable<SerializationRule>
rulesFor(object, Writer w, [create = true]) {
On 2013/05/14 23:18:33, John Messerly wrote:
> consider: named argument here, they tend to be a bit more descriptive for
> booleans.

Done.

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/lib/src/ser...
File pkg/serialization/lib/src/serialization_rule.dart (right):

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/lib/src/ser...
pkg/serialization/lib/src/serialization_rule.dart:507: [date.year, date.month,
date.day, date.hour, date.minute,
On 2013/05/14 23:18:33, John Messerly wrote:
> alternatively, just store millisecondsSinceEpoch and isUtc?

Doh! That's much simpler. Done.

https://codereview.chromium.org/14578008/diff/1/pkg/serialization/lib/src/ser...
pkg/serialization/lib/src/serialization_rule.dart:512: return
Function.apply(creation, state.take(7).toList());
On 2013/05/14 23:18:33, John Messerly wrote:
> TIL: we have Function.apply :)

But now I don't get to use it :-(

[Jennifer Messerly, 2013-05-14 23:48:31]

lgtm!

[Alan Knight, 2013-05-15 17:56:49]

Committed patchset #2 manually as r22750 (presubmit successful).