Put HashMap class in dart namespace.

Put HashMap class in dart namespace.

R=sgjesse@google.com
Signed-off-by: Thiago Farina <tfarina@chromium.org>;

Committed: https://code.google.com/p/dart/source/detail?r=22175

[Søren Gjesse, 2013-04-30 06:22:50]

lgtm

Looking at the code hashmap is currently only used in runtime/bin, so we might
move it there at some point.

[tfarina, 2013-04-30 10:40:14]

Could you land this to me? git cl patch 14572004, git cl dcommit.

Should I ask for commit status, so you guys don't have to waste time doing it
manually for me (based on my commit status history (chromium, blink, skia)? I
don't know if you guys require 10+ non-trivial patches though (and this is
certainly a trivial/cleanup patch).

Regards,

[tfarina, 2013-04-30 10:41:30]

On 2013/04/30 06:22:50, Søren Gjesse wrote:
> Looking at the code hashmap is currently only used in runtime/bin, so we might
> move it there at some point.

If you are fine with moving it, I'll move it in a follow up CL to runtime/bin.

[Søren Gjesse, 2013-04-30 11:48:56]

Committed patchset #1 manually as r22175 (presubmit successful).

[Søren Gjesse, 2013-04-30 11:50:37]

Thanks for the patch. It is now landed. Regarding moving hashmap.* let's
postpone that for a while.

[Ivan Posva, 2013-04-30 15:07:53]

!LGTM

-Ivan

https://codereview.chromium.org/14572004/diff/1/runtime/platform/hashmap.h
File runtime/platform/hashmap.h (right):

https://codereview.chromium.org/14572004/diff/1/runtime/platform/hashmap.h#ne...
runtime/platform/hashmap.h:10: namespace dart {
We should NOT pollute the dart namespace from outside the VM code.

[tfarina, 2013-04-30 16:31:03]

https://codereview.chromium.org/14572004/diff/1/runtime/platform/hashmap.h
File runtime/platform/hashmap.h (right):

https://codereview.chromium.org/14572004/diff/1/runtime/platform/hashmap.h#ne...
runtime/platform/hashmap.h:10: namespace dart {
On 2013/04/30 15:07:53, Ivan Posva wrote:
> We should NOT pollute the dart namespace from outside the VM code.
What is your argument about leaving it in the global namespace? Did you run the
command line "git grep --files-without-match  "namespace dart"
runtime/platform/"?
Why would runtime/vm be special and only it use dart namespace? runtime/bin uses
dart::bin namespace already.

v8 on the other hand has all its implementation in src/ and the types are inside
v8::internal namespace, while the public api is in include/v8.h and in the v8
namespace.

Søren suggested that we would put this also in dart::platform namespace. Which
would be consistent with dart::bin namespace.

But that is mirror, and I wouldn't worry too much about this anyway.

[Søren Gjesse, 2013-05-01 06:28:37]

The hashmap.* files was originally moved from runtime/bin to runtime/platform in
https://code.google.com/p/dart/source/detail?r=10261.

The comment says:

Move hashmap.h and hashmap.cc from the 'bin' directory to 'platform' directory
so that it can be used from VM code too.

Based on that I don't see any issues with placing it in the dart namespace like
the rest in runtime/platform.

On 2013/04/30 16:31:03, tfarina wrote:
> https://codereview.chromium.org/14572004/diff/1/runtime/platform/hashmap.h
> File runtime/platform/hashmap.h (right):
> 
>
https://codereview.chromium.org/14572004/diff/1/runtime/platform/hashmap.h#ne...
> runtime/platform/hashmap.h:10: namespace dart {
> On 2013/04/30 15:07:53, Ivan Posva wrote:
> > We should NOT pollute the dart namespace from outside the VM code.
> What is your argument about leaving it in the global namespace? Did you run
the
> command line "git grep --files-without-match  "namespace dart"
> runtime/platform/"?
> Why would runtime/vm be special and only it use dart namespace? runtime/bin
uses
> dart::bin namespace already.
> 
> v8 on the other hand has all its implementation in src/ and the types are
inside
> v8::internal namespace, while the public api is in include/v8.h and in the v8
> namespace.
> 
> Søren suggested that we would put this also in dart::platform namespace. Which
> would be consistent with dart::bin namespace.
> 
> But that is mirror, and I wouldn't worry too much about this anyway.