Issue 14566020: - Correctly handle negative constant indices when

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14566020: - Correctly handle negative constant indices when (Closed)

Created:
7 years, 7 months ago by Ivan Posva

Modified:
7 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Correctly handle negative constant indices when constant propagation has not eliminated range checks. - Add test to verify the optimizer does not allow negative constant indices when eliminating array bounds checks. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22705

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -41 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+19 lines, -31 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tests/language/optimized_constant_array_string_access_test.dart	View	1 chunk	+14 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

7 years, 7 months ago (2013-05-14 20:33:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22705 (presubmit successful).

Expand Messages | Collapse Messages