Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 14566015: Change default format to produce output that can be passed between isolates (Closed)

Created:
7 years, 7 months ago by Alan Knight
Modified:
7 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change default format to produce output that can be passed between isolates R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=22686

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -22 lines) Patch
M pkg/serialization/lib/src/format.dart View 1 4 chunks +97 lines, -14 lines 0 comments Download
M pkg/serialization/lib/src/reader_writer.dart View 4 chunks +9 lines, -3 lines 0 comments Download
M pkg/serialization/test/serialization_test.dart View 7 chunks +46 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
Change the default serialization format (SimpleMapFormat) to not include Reference objects, but to convert them ...
7 years, 7 months ago (2013-05-13 23:27:03 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/14566015/diff/1/pkg/serialization/lib/src/format.dart File pkg/serialization/lib/src/format.dart (right): https://codereview.chromium.org/14566015/diff/1/pkg/serialization/lib/src/format.dart#newcode119 pkg/serialization/lib/src/format.dart:119: forAllStates(ReaderOrWriter w, Function predicate, Function transform) { more ...
7 years, 7 months ago (2013-05-14 00:21:38 UTC) #2
Alan Knight
7 years, 7 months ago (2013-05-14 16:34:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22686 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698