Issue 145623011: Allow paths up to 32767 characters on Windows (so '\\?\' can be used).

Issue 145623011: Allow paths up to 32767 characters on Windows (so '\\?\' can be used). (Closed)

Created:
6 years, 10 months ago by Anders Johnsen

Modified:
6 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow paths up to 32767 characters on Windows (so '\\?\' can be used). BUG=https://code.google.com/p/dart/issues/detail?id=16264 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=32308

Patch Set 1 #

Patch Set 2 : Add windows file test. #

Total comments: 4

Patch Set 3 : Fix test. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -7 lines)			Patch
	M	runtime/bin/directory_win.cc	View		4 chunks	+10 lines, -7 lines	0 comments	Download
	A	tests/standalone/io/file_windows_test.dart	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

https://codereview.chromium.org/145623011/diff/40002/tests/standalone/io/file_windows_test.dart File tests/standalone/io/file_windows_test.dart (right): https://codereview.chromium.org/145623011/diff/40002/tests/standalone/io/file_windows_test.dart#newcode11 tests/standalone/io/file_windows_test.dart:11: var prefixDir = new Directory('\\\\?\\${dir.path}'); Please create a number ...

6 years, 10 months ago (2014-02-04 13:53:05 UTC) #3

Anders Johnsen

PTAL https://codereview.chromium.org/145623011/diff/40002/tests/standalone/io/file_windows_test.dart File tests/standalone/io/file_windows_test.dart (right): https://codereview.chromium.org/145623011/diff/40002/tests/standalone/io/file_windows_test.dart#newcode11 tests/standalone/io/file_windows_test.dart:11: var prefixDir = new Directory('\\\\?\\${dir.path}'); On 2014/02/04 13:53:05, ...

6 years, 10 months ago (2014-02-04 14:00:20 UTC) #4

Anders Johnsen

6 years, 10 months ago (2014-02-05 07:28:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r32308 (presubmit successful).

Expand Messages | Collapse Messages