Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 14544009: Fix some doc formatting problems, stop using "set" methods for NumberFormat (Closed)

Created:
7 years, 7 months ago by Alan Knight
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix some doc formatting problems, stop using "set" methods for NumberFormat R=amouravski@google.com, sethladd@google.com Committed: https://code.google.com/p/dart/source/detail?r=22148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -88 lines) Patch
M pkg/intl/lib/date_format.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/number_format.dart View 15 chunks +44 lines, -79 lines 0 comments Download
M pkg/intl/test/number_closure_test.dart View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alan Knight
Addresses 10251 NumberFormat uses non-Darty setFoo instead of setters 10287 Incorrect documentation in DateFormat class ...
7 years, 7 months ago (2013-04-29 20:15:37 UTC) #1
sethladd
lgtm thanks!
7 years, 7 months ago (2013-04-29 20:17:29 UTC) #2
Andrei Mouravski
lgtm
7 years, 7 months ago (2013-04-29 20:18:32 UTC) #3
Alan Knight
7 years, 7 months ago (2013-04-29 20:32:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22148 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698