Add LibraryLoader.resetLibraries

Add LibraryLoader.resetLibraries

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/f8cf5fffc8044abf8e9ae61a0c65f6a5e1a51310

[ahe, 2015-11-19 09:54:12]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2015-11-19 10:04:31]

lgtm

https://codereview.chromium.org/1454383002/diff/1/pkg/compiler/lib/src/librar...
File pkg/compiler/lib/src/library_loader.dart (right):

https://codereview.chromium.org/1454383002/diff/1/pkg/compiler/lib/src/librar...
pkg/compiler/lib/src/library_loader.dart:162: Future<Iterable<LibraryElement>>
reuseLibraries(
Maybe typedef this to make it more readable.

[ahe, 2015-11-19 11:20:56]

https://codereview.chromium.org/1454383002/diff/1/pkg/compiler/lib/src/librar...
File pkg/compiler/lib/src/library_loader.dart (right):

https://codereview.chromium.org/1454383002/diff/1/pkg/compiler/lib/src/librar...
pkg/compiler/lib/src/library_loader.dart:162: Future<Iterable<LibraryElement>>
reuseLibraries(
On 2015/11/19 10:04:31, Johnni Winther wrote:
> Maybe typedef this to make it more readable.

I find typedefs less readable, but if you prefer a typedef, I'll use a typedef.
Let me know.

[Johnni Winther, 2015-11-19 11:25:37]

lgtm

https://codereview.chromium.org/1454383002/diff/1/pkg/compiler/lib/src/librar...
File pkg/compiler/lib/src/library_loader.dart (right):

https://codereview.chromium.org/1454383002/diff/1/pkg/compiler/lib/src/librar...
pkg/compiler/lib/src/library_loader.dart:162: Future<Iterable<LibraryElement>>
reuseLibraries(
On 2015/11/19 11:20:56, ahe wrote:
> On 2015/11/19 10:04:31, Johnni Winther wrote:
> > Maybe typedef this to make it more readable.
> 
> I find typedefs less readable, but if you prefer a typedef, I'll use a
typedef.
> Let me know.

In this case where the signature is too long, I do:

typedef Future<Iterable<LibraryElement>> ReuseLibrariesFunction(
     Iterable<LibraryElement> libraries));

Future<Null> resetLibraries(ReuseLibrariesFunction reuseLibraries);

[ahe, 2015-11-19 11:33:14]

https://codereview.chromium.org/1454383002/diff/1/pkg/compiler/lib/src/librar...
File pkg/compiler/lib/src/library_loader.dart (right):

https://codereview.chromium.org/1454383002/diff/1/pkg/compiler/lib/src/librar...
pkg/compiler/lib/src/library_loader.dart:162: Future<Iterable<LibraryElement>>
reuseLibraries(
On 2015/11/19 11:25:37, Johnni Winther wrote:
> On 2015/11/19 11:20:56, ahe wrote:
> > On 2015/11/19 10:04:31, Johnni Winther wrote:
> > > Maybe typedef this to make it more readable.
> > 
> > I find typedefs less readable, but if you prefer a typedef, I'll use a
> typedef.
> > Let me know.
> 
> In this case where the signature is too long, I do:
> 
> typedef Future<Iterable<LibraryElement>> ReuseLibrariesFunction(
>      Iterable<LibraryElement> libraries));
> 
> Future<Null> resetLibraries(ReuseLibrariesFunction reuseLibraries);

OK. Calling it *Function helps a bit.

[ahe, 2016-01-08 10:25:24]

https://codereview.chromium.org/1454383002/diff/1/pkg/compiler/lib/src/librar...
File pkg/compiler/lib/src/library_loader.dart (right):

https://codereview.chromium.org/1454383002/diff/1/pkg/compiler/lib/src/librar...
pkg/compiler/lib/src/library_loader.dart:162: Future<Iterable<LibraryElement>>
reuseLibraries(
On 2015/11/19 11:33:13, ahe wrote:
> On 2015/11/19 11:25:37, Johnni Winther wrote:
> > On 2015/11/19 11:20:56, ahe wrote:
> > > On 2015/11/19 10:04:31, Johnni Winther wrote:
> > > > Maybe typedef this to make it more readable.
> > > 
> > > I find typedefs less readable, but if you prefer a typedef, I'll use a
> > typedef.
> > > Let me know.
> > 
> > In this case where the signature is too long, I do:
> > 
> > typedef Future<Iterable<LibraryElement>> ReuseLibrariesFunction(
> >      Iterable<LibraryElement> libraries));
> > 
> > Future<Null> resetLibraries(ReuseLibrariesFunction reuseLibraries);
> 
> OK. Calling it *Function helps a bit.

Done.

[ahe, 2016-01-08 10:28:35]

Description was changed from

==========
Add LibraryLoader.resetLibraries
==========

to

==========
Add LibraryLoader.resetLibraries

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f8cf5fffc8044abf8e9ae61a0c65f6a5e1a51310
==========

[ahe, 2016-01-08 10:28:36]

Committed patchset #3 (id:40001) manually as
f8cf5fffc8044abf8e9ae61a0c65f6a5e1a51310 (presubmit successful).