Issue 145403005: pkg/unittest: formatter spin

Issue 145403005: pkg/unittest: formatter spin (Closed)

Created:
6 years, 10 months ago by kevmoo

Modified:
6 years, 10 months ago

Reviewers:
Emily Fortuna, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/unittest: formatter spin R=efortuna@google.com, sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32152

Patch Set 2 : review nits #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -47 lines)			Patch
M	pkg/unittest/lib/html_config.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/lib/html_enhanced_config.dart	View		5 chunks	+9 lines, -9 lines	0 comments	Download
M	pkg/unittest/lib/interactive_html_config.dart	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	pkg/unittest/lib/src/core_matchers.dart	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/unittest/lib/src/iterable_matchers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/lib/src/numeric_matchers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/lib/src/test_case.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/unittest/lib/src/utils.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/lib/unittest.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/unittest/test/mirror_matchers_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/test/mock_stepwise_negative_test.dart	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	pkg/unittest/test/mock_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/test/test_common.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/test/unittest_completion_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/test/unittest_skipped_soloed_nested_test.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/unittest/test/unittest_test_utils.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo

Trivial pass on the formatter before I dig in on other issues

6 years, 10 months ago (2014-01-30 01:15:32 UTC) #1

Siggi Cherem (dart-lang)

nice! lgtm https://codereview.chromium.org/145403005/diff/1/pkg/unittest/test/mock_stepwise_negative_test.dart File pkg/unittest/test/mock_stepwise_negative_test.dart (right): https://codereview.chromium.org/145403005/diff/1/pkg/unittest/test/mock_stepwise_negative_test.dart#newcode19 pkg/unittest/test/mock_stepwise_negative_test.dart:19: }); consider changing this one as: logList.stepwiseValidate((log, ...

6 years, 10 months ago (2014-01-30 01:20:02 UTC) #2

Emily Fortuna

yay, lgtm! https://codereview.chromium.org/145403005/diff/1/pkg/unittest/test/mock_stepwise_negative_test.dart File pkg/unittest/test/mock_stepwise_negative_test.dart (right): https://codereview.chromium.org/145403005/diff/1/pkg/unittest/test/mock_stepwise_negative_test.dart#newcode19 pkg/unittest/test/mock_stepwise_negative_test.dart:19: }); On 2014/01/30 01:20:03, Siggi Cherem (dart-lang) ...

6 years, 10 months ago (2014-01-30 01:27:52 UTC) #3

kevmoo

6 years, 10 months ago (2014-01-30 05:20:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r32152 (presubmit successful).

Expand Messages | Collapse Messages